Skip to content

Add Otel Metrics configuration keys #9868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Nov 6, 2025
Merged

Add Otel Metrics configuration keys #9868

merged 41 commits into from
Nov 6, 2025

Conversation

@cecile75
Copy link
Contributor

@cecile75 cecile75 commented Oct 27, 2025 •
edited
Loading

What Does This Do

Add the following configuration keys:

  • dd.metrics.otel.enabled
  • otel.metric.export.interval
  • otel.metric.export.timeout
  • otel.exporter.otlp.metrics.endpoint
  • otel.exporter.otlp.metrics.headers
  • otel.exporter.otlp.metrics.protocol
  • otel.exporter.otlp.metrics.timeout
  • otel.exporter.otlp.metrics.temporality.preference
  • otel.metrics.exporter

They are not linked to anything yet.

Motivation

OpenTelemetry Metrics API support

Additional Notes

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Oct 29, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 59.60% (-0.09%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 24185f1 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 29, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/otelmetricstask1
git_commit_date 1762297540 1762423458
git_commit_sha 8db72c0 24185f1
release_version 1.56.0-SNAPSHOT~8db72c0988 1.55.0-SNAPSHOT~24185f1081
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1762425456 1762425456
ci_job_id 1219179003 1219179003
ci_pipeline_id 81430182 81430182
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-flv0nk8z 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-flv0nk8z 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:tracing:Remote Config better
[-58.961µs; -23.565µs] or [-8.234%; -3.291%]		 674.840µs 716.103µs
scenario:startup:petclinic:tracing:Remote Config better
[-65.548µs; -29.606µs] or [-9.047%; -4.086%]		 676.925µs 724.501µs
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~24185f1081, baseline=1.56.0-SNAPSHOT~8db72c0988

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053959
Total [baseline] (8.65 s) : 0, 8649757
Agent [candidate] (1.031 s) : 0, 1031161
Total [candidate] (8.683 s) : 0, 8683099
section iast
Agent [baseline] (1.183 s) : 0, 1183210
Total [baseline] (9.303 s) : 0, 9303183
Agent [candidate] (1.165 s) : 0, 1165042
Total [candidate] (9.404 s) : 0, 9404467
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.183 s 129.251 ms (12.3%)
Total tracing 8.65 s -
Total iast 9.303 s 653.426 ms (7.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.031 s -
Agent iast 1.165 s 133.881 ms (13.0%)
Total tracing 8.683 s -
Total iast 9.404 s 721.368 ms (8.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~24185f1081, baseline=1.56.0-SNAPSHOT~8db72c0988

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (710.418 ms) : 0, 710418
BytebuddyAgent [candidate] (703.592 ms) : 0, 703592
GlobalTracer [baseline] (246.466 ms) : 0, 246466
GlobalTracer [candidate] (244.854 ms) : 0, 244854
AppSec [baseline] (32.633 ms) : 0, 32633
AppSec [candidate] (32.176 ms) : 0, 32176
Debugger [baseline] (6.42 ms) : 0, 6420
Debugger [candidate] (6.367 ms) : 0, 6367
Remote Config [baseline] (716.103 µs) : 0, 716
Remote Config [candidate] (674.84 µs) : 0, 675
Telemetry [baseline] (12.136 ms) : 0, 12136
Telemetry [candidate] (15.136 ms) : 0, 15136
Flare Poller [baseline] (8.959 ms) : 0, 8959
Flare Poller [candidate] (5.698 ms) : 0, 5698
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (830.404 ms) : 0, 830404
BytebuddyAgent [candidate] (826.542 ms) : 0, 826542
GlobalTracer [baseline] (235.79 ms) : 0, 235790
GlobalTracer [candidate] (234.716 ms) : 0, 234716
AppSec [baseline] (28.052 ms) : 0, 28052
AppSec [candidate] (29.98 ms) : 0, 29980
Debugger [baseline] (6.028 ms) : 0, 6028
Debugger [candidate] (6.117 ms) : 0, 6117
Remote Config [baseline] (608.703 µs) : 0, 609
Remote Config [candidate] (595.562 µs) : 0, 596
Telemetry [baseline] (8.438 ms) : 0, 8438
Telemetry [candidate] (8.457 ms) : 0, 8457
Flare Poller [baseline] (4.147 ms) : 0, 4147
Flare Poller [candidate] (4.172 ms) : 0, 4172
IAST [baseline] (33.742 ms) : 0, 33742
IAST [candidate] (31.725 ms) : 0, 31725
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~24185f1081, baseline=1.56.0-SNAPSHOT~8db72c0988

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047654
Total [baseline] (10.731 s) : 0, 10731057
Agent [candidate] (1.031 s) : 0, 1030774
Total [candidate] (10.772 s) : 0, 10772347
section appsec
Agent [baseline] (1.229 s) : 0, 1228755
Total [baseline] (10.915 s) : 0, 10915434
Agent [candidate] (1.203 s) : 0, 1202563
Total [candidate] (10.856 s) : 0, 10856325
section iast
Agent [baseline] (1.178 s) : 0, 1177663
Total [baseline] (11.134 s) : 0, 11133874
Agent [candidate] (1.16 s) : 0, 1160384
Total [candidate] (11.088 s) : 0, 11088250
section profiling
Agent [baseline] (1.193 s) : 0, 1192903
Total [baseline] (10.912 s) : 0, 10911785
Agent [candidate] (1.171 s) : 0, 1170893
Total [candidate] (10.823 s) : 0, 10823003
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.229 s 181.101 ms (17.3%)
Agent iast 1.178 s 130.008 ms (12.4%)
Agent profiling 1.193 s 145.249 ms (13.9%)
Total tracing 10.731 s -
Total appsec 10.915 s 184.377 ms (1.7%)
Total iast 11.134 s 402.816 ms (3.8%)
Total profiling 10.912 s 180.728 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.031 s -
Agent appsec 1.203 s 171.789 ms (16.7%)
Agent iast 1.16 s 129.61 ms (12.6%)
Agent profiling 1.171 s 140.119 ms (13.6%)
Total tracing 10.772 s -
Total appsec 10.856 s 83.978 ms (0.8%)
Total iast 11.088 s 315.903 ms (2.9%)
Total profiling 10.823 s 50.656 ms (0.5%) 
gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~24185f1081, baseline=1.56.0-SNAPSHOT~8db72c0988

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (704.547 ms) : 0, 704547
BytebuddyAgent [candidate] (703.113 ms) : 0, 703113
GlobalTracer [baseline] (246.475 ms) : 0, 246475
GlobalTracer [candidate] (244.898 ms) : 0, 244898
AppSec [baseline] (32.686 ms) : 0, 32686
AppSec [candidate] (32.389 ms) : 0, 32389
Debugger [baseline] (6.454 ms) : 0, 6454
Debugger [candidate] (6.372 ms) : 0, 6372
Remote Config [baseline] (724.501 µs) : 0, 725
Remote Config [candidate] (676.925 µs) : 0, 677
Telemetry [baseline] (14.347 ms) : 0, 14347
Telemetry [candidate] (14.935 ms) : 0, 14935
Flare Poller [baseline] (6.374 ms) : 0, 6374
Flare Poller [candidate] (5.802 ms) : 0, 5802
section appsec
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (733.77 ms) : 0, 733770
BytebuddyAgent [candidate] (725.596 ms) : 0, 725596
GlobalTracer [baseline] (238.46 ms) : 0, 238460
GlobalTracer [candidate] (236.11 ms) : 0, 236110
AppSec [baseline] (175.791 ms) : 0, 175791
AppSec [candidate] (174.289 ms) : 0, 174289
Debugger [baseline] (6.068 ms) : 0, 6068
Debugger [candidate] (5.928 ms) : 0, 5928
Remote Config [baseline] (657.761 µs) : 0, 658
Remote Config [candidate] (633.283 µs) : 0, 633
Telemetry [baseline] (8.685 ms) : 0, 8685
Telemetry [candidate] (8.418 ms) : 0, 8418
Flare Poller [baseline] (3.97 ms) : 0, 3970
Flare Poller [candidate] (3.858 ms) : 0, 3858
IAST [baseline] (25.014 ms) : 0, 25014
IAST [candidate] (25.072 ms) : 0, 25072
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (826.504 ms) : 0, 826504
BytebuddyAgent [candidate] (823.644 ms) : 0, 823644
GlobalTracer [baseline] (234.778 ms) : 0, 234778
GlobalTracer [candidate] (233.483 ms) : 0, 233483
AppSec [baseline] (28.779 ms) : 0, 28779
AppSec [candidate] (28.858 ms) : 0, 28858
Debugger [baseline] (6.049 ms) : 0, 6049
Debugger [candidate] (6.047 ms) : 0, 6047
Remote Config [baseline] (591.741 µs) : 0, 592
Remote Config [candidate] (597.575 µs) : 0, 598
Telemetry [baseline] (8.316 ms) : 0, 8316
Telemetry [candidate] (8.411 ms) : 0, 8411
Flare Poller [baseline] (4.192 ms) : 0, 4192
Flare Poller [candidate] (4.165 ms) : 0, 4165
IAST [baseline] (32.349 ms) : 0, 32349
IAST [candidate] (32.527 ms) : 0, 32527
section profiling
ProfilingAgent [baseline] (110.754 ms) : 0, 110754
ProfilingAgent [candidate] (108.628 ms) : 0, 108628
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (729.024 ms) : 0, 729024
BytebuddyAgent [candidate] (724.844 ms) : 0, 724844
GlobalTracer [baseline] (222.082 ms) : 0, 222082
GlobalTracer [candidate] (220.04 ms) : 0, 220040
AppSec [baseline] (32.096 ms) : 0, 32096
AppSec [candidate] (32.256 ms) : 0, 32256
Debugger [baseline] (7.544 ms) : 0, 7544
Debugger [candidate] (12.281 ms) : 0, 12281
Remote Config [baseline] (683.381 µs) : 0, 683
Remote Config [candidate] (1.406 ms) : 0, 1406
Telemetry [baseline] (14.955 ms) : 0, 14955
Telemetry [candidate] (9.949 ms) : 0, 9949
Flare Poller [baseline] (4.265 ms) : 0, 4265
Flare Poller [candidate] (4.139 ms) : 0, 4139
Profiling [baseline] (111.412 ms) : 0, 111412
Profiling [candidate] (109.25 ms) : 0, 109250
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/otelmetricstask1
git_commit_date 1762297540 1762423458
git_commit_sha 8db72c0 24185f1
release_version 1.56.0-SNAPSHOT~8db72c0988 1.55.0-SNAPSHOT~24185f1081
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1762425951 1762425951
ci_job_id 1219179004 1219179004
ci_pipeline_id 81430182 81430182
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-3-oagwoxxi 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-3-oagwoxxi 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 5 performance regressions! Performance is the same for 5 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load better
[-224.136µs; -94.580µs] or [-6.019%; -2.540%]		 unstable
[-90.509op/s; +199.822op/s] or [-7.348%; +16.222%]		 3.565ms 1286.438op/s 3.724ms 1231.781op/s
scenario:load:petclinic:iast:high_load worse
[+1.627ms; +2.034ms] or [+9.026%; +11.285%]		 unstable
[-50.783op/s; +3.283op/s] or [-19.617%; +1.268%]		 19.854ms 235.125op/s 18.023ms 258.875op/s
scenario:load:petclinic:appsec:high_load worse
[+1.657ms; +2.079ms] or [+8.943%; +11.222%]		 unstable
[-48.975op/s; +3.100op/s] or [-19.447%; +1.231%]		 20.398ms 228.906op/s 18.530ms 251.844op/s
scenario:load:petclinic:code_origins:high_load worse
[+1.226ms; +1.634ms] or [+6.743%; +8.986%]		 unstable
[-45.400op/s; +8.087op/s] or [-17.695%; +3.152%]		 19.620ms 237.906op/s 18.189ms 256.562op/s
scenario:load:petclinic:no_agent:high_load better
[-1.543ms; -1.127ms] or [-7.978%; -5.829%]		 unstable
[-11.070op/s; +46.570op/s] or [-4.586%; +19.294%]		 18.005ms 259.125op/s 19.340ms 241.375op/s
scenario:load:petclinic:tracing:high_load worse
[+699.267µs; +1094.014µs] or [+3.934%; +6.155%]		 unstable
[-40.644op/s; +15.581op/s] or [-15.481%; +5.935%]		 18.672ms 250.000op/s 17.775ms 262.531op/s
scenario:load:petclinic:profiling:high_load worse
[+1.652ms; +2.086ms] or [+8.736%; +11.036%]		 unstable
[-47.762op/s; +3.574op/s] or [-19.347%; +1.448%]		 20.774ms 224.781op/s 18.905ms 246.875op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~24185f1081, baseline=1.56.0-SNAPSHOT~8db72c0988
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.219 ms) : 1207, 1232
.   : milestone, 1219,
iast (3.239 ms) : 3190, 3288
.   : milestone, 3239,
iast_FULL (5.729 ms) : 5672, 5786
.   : milestone, 5729,
iast_GLOBAL (3.724 ms) : 3660, 3788
.   : milestone, 3724,
profiling (1.863 ms) : 1848, 1878
.   : milestone, 1863,
tracing (1.809 ms) : 1793, 1825
.   : milestone, 1809,
section candidate
no_agent (1.213 ms) : 1202, 1225
.   : milestone, 1213,
iast (3.197 ms) : 3153, 3242
.   : milestone, 3197,
iast_FULL (5.787 ms) : 5729, 5845
.   : milestone, 5787,
iast_GLOBAL (3.565 ms) : 3508, 3621
.   : milestone, 3565,
profiling (1.899 ms) : 1882, 1915
.   : milestone, 1899,
tracing (1.853 ms) : 1837, 1868
.   : milestone, 1853,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.219 ms [1.207 ms, 1.232 ms] -
iast 3.239 ms [3.19 ms, 3.288 ms] 2.02 ms (165.6%)
iast_FULL 5.729 ms [5.672 ms, 5.786 ms] 4.51 ms (369.8%)
iast_GLOBAL 3.724 ms [3.66 ms, 3.788 ms] 2.505 ms (205.4%)
profiling 1.863 ms [1.848 ms, 1.878 ms] 643.86 µs (52.8%)
tracing 1.809 ms [1.793 ms, 1.825 ms] 589.673 µs (48.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.213 ms [1.202 ms, 1.225 ms] -
iast 3.197 ms [3.153 ms, 3.242 ms] 1.984 ms (163.5%)
iast_FULL 5.787 ms [5.729 ms, 5.845 ms] 4.573 ms (376.9%)
iast_GLOBAL 3.565 ms [3.508 ms, 3.621 ms] 2.351 ms (193.8%)
profiling 1.899 ms [1.882 ms, 1.915 ms] 685.221 µs (56.5%)
tracing 1.853 ms [1.837 ms, 1.868 ms] 639.255 µs (52.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~24185f1081, baseline=1.56.0-SNAPSHOT~8db72c0988
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.34 ms) : 19137, 19543
.   : milestone, 19340,
appsec (18.53 ms) : 18341, 18718
.   : milestone, 18530,
code_origins (18.189 ms) : 18007, 18371
.   : milestone, 18189,
iast (18.023 ms) : 17845, 18202
.   : milestone, 18023,
profiling (18.905 ms) : 18711, 19098
.   : milestone, 18905,
tracing (17.775 ms) : 17599, 17951
.   : milestone, 17775,
section candidate
no_agent (18.005 ms) : 17823, 18187
.   : milestone, 18005,
appsec (20.398 ms) : 20194, 20602
.   : milestone, 20398,
code_origins (19.62 ms) : 19422, 19817
.   : milestone, 19620,
iast (19.854 ms) : 19654, 20053
.   : milestone, 19854,
profiling (20.774 ms) : 20563, 20984
.   : milestone, 20774,
tracing (18.672 ms) : 18481, 18862
.   : milestone, 18672,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.34 ms [19.137 ms, 19.543 ms] -
appsec 18.53 ms [18.341 ms, 18.718 ms] -810.411 µs (-4.2%)
code_origins 18.189 ms [18.007 ms, 18.371 ms] -1.151 ms (-6.0%)
iast 18.023 ms [17.845 ms, 18.202 ms] -1.317 ms (-6.8%)
profiling 18.905 ms [18.711 ms, 19.098 ms] -435.32 µs (-2.3%)
tracing 17.775 ms [17.599 ms, 17.951 ms] -1.565 ms (-8.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.005 ms [17.823 ms, 18.187 ms] -
appsec 20.398 ms [20.194 ms, 20.602 ms] 2.393 ms (13.3%)
code_origins 19.62 ms [19.422 ms, 19.817 ms] 1.615 ms (9.0%)
iast 19.854 ms [19.654 ms, 20.053 ms] 1.849 ms (10.3%)
profiling 20.774 ms [20.563 ms, 20.984 ms] 2.769 ms (15.4%)
tracing 18.672 ms [18.481 ms, 18.862 ms] 666.733 µs (3.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/otelmetricstask1
git_commit_date 1762297540 1762423458
git_commit_sha 8db72c0 24185f1
release_version 1.56.0-SNAPSHOT~8db72c0988 1.55.0-SNAPSHOT~24185f1081
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1762425602 1762425602
ci_job_id 1219179005 1219179005
ci_pipeline_id 81430182 81430182
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-5xwledk6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-5xwledk6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~24185f1081, baseline=1.56.0-SNAPSHOT~8db72c0988
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1493
.   : milestone, 1481,
appsec (2.507 ms) : 2454, 2560
.   : milestone, 2507,
iast (2.225 ms) : 2161, 2289
.   : milestone, 2225,
iast_GLOBAL (2.255 ms) : 2192, 2319
.   : milestone, 2255,
profiling (2.514 ms) : 2342, 2686
.   : milestone, 2514,
tracing (2.027 ms) : 1977, 2076
.   : milestone, 2027,
section candidate
no_agent (1.481 ms) : 1469, 1492
.   : milestone, 1481,
appsec (3.695 ms) : 3478, 3911
.   : milestone, 3695,
iast (2.216 ms) : 2152, 2280
.   : milestone, 2216,
iast_GLOBAL (2.262 ms) : 2197, 2326
.   : milestone, 2262,
profiling (2.063 ms) : 2011, 2114
.   : milestone, 2063,
tracing (2.041 ms) : 1991, 2091
.   : milestone, 2041,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.481 ms [1.469 ms, 1.493 ms] -
appsec 2.507 ms [2.454 ms, 2.56 ms] 1.026 ms (69.3%)
iast 2.225 ms [2.161 ms, 2.289 ms] 744.049 µs (50.2%)
iast_GLOBAL 2.255 ms [2.192 ms, 2.319 ms] 774.413 µs (52.3%)
profiling 2.514 ms [2.342 ms, 2.686 ms] 1.033 ms (69.8%)
tracing 2.027 ms [1.977 ms, 2.076 ms] 545.942 µs (36.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.481 ms [1.469 ms, 1.492 ms] -
appsec 3.695 ms [3.478 ms, 3.911 ms] 2.214 ms (149.5%)
iast 2.216 ms [2.152 ms, 2.28 ms] 735.202 µs (49.6%)
iast_GLOBAL 2.262 ms [2.197 ms, 2.326 ms] 780.645 µs (52.7%)
profiling 2.063 ms [2.011 ms, 2.114 ms] 581.964 µs (39.3%)
tracing 2.041 ms [1.991 ms, 2.091 ms] 559.893 µs (37.8%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~24185f1081, baseline=1.56.0-SNAPSHOT~8db72c0988
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.561 s) : 15561000, 15561000
.   : milestone, 15561000,
appsec (14.839 s) : 14839000, 14839000
.   : milestone, 14839000,
iast (18.7 s) : 18700000, 18700000
.   : milestone, 18700000,
iast_GLOBAL (18.037 s) : 18037000, 18037000
.   : milestone, 18037000,
profiling (14.682 s) : 14682000, 14682000
.   : milestone, 14682000,
tracing (15.162 s) : 15162000, 15162000
.   : milestone, 15162000,
section candidate
no_agent (15.41 s) : 15410000, 15410000
.   : milestone, 15410000,
appsec (14.933 s) : 14933000, 14933000
.   : milestone, 14933000,
iast (18.425 s) : 18425000, 18425000
.   : milestone, 18425000,
iast_GLOBAL (17.975 s) : 17975000, 17975000
.   : milestone, 17975000,
profiling (15.752 s) : 15752000, 15752000
.   : milestone, 15752000,
tracing (15.427 s) : 15427000, 15427000
.   : milestone, 15427000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.561 s [15.561 s, 15.561 s] -
appsec 14.839 s [14.839 s, 14.839 s] -722.0 ms (-4.6%)
iast 18.7 s [18.7 s, 18.7 s] 3.139 s (20.2%)
iast_GLOBAL 18.037 s [18.037 s, 18.037 s] 2.476 s (15.9%)
profiling 14.682 s [14.682 s, 14.682 s] -879.0 ms (-5.6%)
tracing 15.162 s [15.162 s, 15.162 s] -399.0 ms (-2.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.41 s [15.41 s, 15.41 s] -
appsec 14.933 s [14.933 s, 14.933 s] -477.0 ms (-3.1%)
iast 18.425 s [18.425 s, 18.425 s] 3.015 s (19.6%)
iast_GLOBAL 17.975 s [17.975 s, 17.975 s] 2.565 s (16.6%)
profiling 15.752 s [15.752 s, 15.752 s] 342.0 ms (2.2%)
tracing 15.427 s [15.427 s, 15.427 s] 17.0 ms (0.1%)

@cecile75 cecile75 added inst: opentelemetry OpenTelemetry instrumentation tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements labels Oct 29, 2025
@cecile75 cecile75 marked this pull request as ready for review October 29, 2025 16:46
@cecile75 cecile75 requested review from a team as code owners October 29, 2025 16:46
@cecile75 cecile75 requested review from mcculls, mhlidd and sarahchen6 and removed request for a team October 29, 2025 16:46
mhlidd
mhlidd requested changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@mhlidd mhlidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have time to review all test files, but I have a general concern about where we should handle OTel configurations. We already have OTelEnvironmentConfigSource, which is effectively sets Datadog Configs as aliases for OTel Configs when DD_TRACE_OTEL_ENABLED=true.

IMO we should handle all OTel configs in one place to have one source of truth, and to me it makes sense to isolate them in OTelEnvironmentConfigSource. WDYT?

internal-api/src/main/java/datadog/trace/api/Config.java Outdated
runtimeMetricsEnabled = configProvider.getBoolean(RUNTIME_METRICS_ENABLED, true);
metricsOtelEnabled =
configProvider.getBoolean(METRICS_OTEL_ENABLED, DEFAULT_METRICS_OTEL_ENABLED);
otelResourceAttributes = configProvider.getMergedMap(OTEL_RESOURCE_ATTRIBUTES, '=');
Copy link
Contributor

@mhlidd mhlidd Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already queried in OtelEnvironmentConfigSource, and it appears that the existing way of handling of this config is slightly more specific than what is happening here.

Do we have a consensus of how we would like to handle this config?

This also brings up a bigger question of whether or not we want to reclassify what OtelEnvironmentConfigSource does. It really is not its own config source, but rather prioritizing OTEL configs instead of their DD equivalents when DD_TRACE_OTEL_ENABLED = true. Should we have all OTEL configs handled in the OtelEnvironmentConfigSource, or should we migrate all of the configs handled there to be handled in Config.java?

IMO, it makes sense to handle all OTel Configs in OtelEnvironmentConfigSource to separate them from regular DD config handling, and to keep the handling of OTel Configs all in one place.

@cecile75 cecile75 marked this pull request as ready for review November 3, 2025 19:43
@mcculls mcculls force-pushed the cecile/otelmetricstask1 branch 2 times, most recently from 42a2955 to 83d93b9 Compare November 4, 2025 23:51
mcculls added 18 commits November 6, 2025 00:11
@mcculls
Cleanup OTel constants
0284268
@mcculls
Put defaults in consistent location
a7186cb
@mcculls
Update comment
55f786c
@mcculls
Replace concat call with +
98ff65e
@mcculls
Revert change to ConfigStrings
b10fea3
@mcculls
Rename OtelMetricsConfig to OtlpConfig and drop Exporter enum as it d…
b392236 
…oesn't add value
@mcculls
Make ConfigProvider.getEnum more robust: make value uppercase and rep…
4c2385b 
…lace known bad characters before converting
@mcculls
Cleanup ConfigDefaults
71600b1
@mcculls
Ensure agentHost is never empty
c38ce90
@mcculls
Cleanup metrics internal config
16cbde4
@mcculls
Remove static import
a0a62b5
@mcculls
Cleanup metrics internal OTLP config
7e4a11f
@mcculls
Add new DD metrics keys
501f78e
@mcculls
Update test expectations: default protocol is now HTTP/PROTOBUF
2d16f0a
@mcculls
Move OTel mappings out of Config
a75665d
@mcculls
Implement OTel metrics mappings in OtelEnvironmentConfigSource
80d2365
@mcculls
Cleanup
5b3d5ae
@mcculls
Warn when any OTel timeouts/intervals are configured with negative va…
90ccc7b 
…lues
@mcculls mcculls force-pushed the cecile/otelmetricstask1 branch from 83d93b9 to 90ccc7b Compare November 6, 2025 02:46
@mcculls
Copy link
Contributor

mcculls commented Nov 6, 2025 •
edited
Loading

I refactored things to introduce (internal) Datadog equivalents of the OTel configuration keys. We now do most of the handling in OtelEnvironmentConfigSource leaving just the exposure of the final resolved configuration in Config.

This also means that we have a way to adjust things if necessary with overrides that apply to Datadog SDKs without affecting any OTel SDKs that might be consuming the same config.

I also made enum conversion case-insensitive as well as automatically map invalid characters (currently just /) to _ before attempting to convert the string to an enum. This is safe to do for existing callers and aligns the behaviour with OTel SDKs.

Finally I changed the default protocol to be http/protobuf to match the behaviour in the current stable OTel Java SDK.

@cecile75 cecile75 merged commit 19d774d into master Nov 6, 2025
539 checks passed
@cecile75 cecile75 deleted the cecile/otelmetricstask1 branch November 6, 2025 13:29
@github-actions github-actions bot added this to the 1.56.0 milestone Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes

@mhlidd mhlidd mhlidd approved these changes

@sarahchen6 sarahchen6 Awaiting requested review from sarahchen6 sarahchen6 is a code owner automatically assigned from DataDog/apm-lang-platform-java

Assignees

No one assigned

Labels

inst: opentelemetry OpenTelemetry instrumentation tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cecile75 @mhlidd @mcculls